Automatic encryption and decryption of emails
ClosedPublic

Authored by dvratil on Aug 1 2017, 5:07 PM.

Details

Summary

Introduce Encrypt (with re-encrypt functionality) and Decrypt message filters to automatically perform
crypto operations on incoming emails.

Diff Detail

Repository
R92 PIM: Common Mail Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Aug 1 2017, 5:07 PM
Restricted Application added a subscriber: KDE PIM. · View Herald TranscriptAug 1 2017, 5:07 PM
mlaurent edited edge metadata.Aug 2 2017, 5:04 AM

You need to increase Messagelib version I increased it as you installed new headers.
you need to increase dependencies
thanks

src/filter/autotests/filteractionencrypttest.cpp
36

perhaps add a qCWarning here when we can't create dest dir

44

same here. More easy to debug

49

same

src/filter/autotests/filteractionencrypttest.h
28

Remove this new line

src/filter/filteractions/filteractionencrypt.h
42

remove space after &

dvratil updated this revision to Diff 17555.Aug 2 2017, 10:44 AM
  • add Decrypt filter + tests
  • refactor unit tests
dvratil updated this revision to Diff 17571.Aug 2 2017, 2:22 PM
  • add Re-encrypt checkbox to the "Encrypt" filter
  • refactoring of filtres to share common decryption code
dvratil updated this revision to Diff 17700.Aug 4 2017, 10:06 AM
dvratil retitled this revision from [WIP] Automatic encryption and decryption of emails to Automatic encryption and decryption of emails.
dvratil edited the summary of this revision. (Show Details)
mlaurent added inline comments.Aug 4 2017, 11:12 AM
src/filter/filteractions/filteractiondecrypt.cpp
36

I think that you can remove this namespace {...}

dvratil updated this revision to Diff 17724.Aug 4 2017, 5:37 PM
  • Don't re-encrypt emails if they are already encrypted with the chosen key
  • Fixes and improvements
This revision was automatically updated to reflect the committed changes.