Differential D702

Move root logic to MessagePart.
AbandonedPublic
Actions

Authored by knauss on Dec 27 2015, 1:51 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM
Maniphest Tasks
T719: Refactor objecttreeparser

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
knauss updated this revision to Diff 1633.Dec 27 2015, 1:51 PM
knauss retitled this revision from to Move root logic to MessagePart..
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: vkrause.
knauss added a task: T719: Refactor objecttreeparser.
knauss added a reviewer: KDE PIM.Dec 27 2015, 2:06 PM
knauss set the repository for this revision to R43 KDE PIM.
knauss added a project: KDE PIM.
dvratil added a subscriber: dvratil.Dec 28 2015, 12:08 PM
dvratil added inline comments.
messageviewer/src/viewer/messagepart.cpp
369

Call parent ctor

551

I assume the point of the rblock pointer is so that the object is auto-destroyed when this method returns, so that internalExit() is called?

Wouldn't using QScopedPointer be more reasonable (and obvious) in such case?

messageviewer/src/viewer/messagepart.h
246

Maybe setIsRoot() and isRoot() would be a better name?

knauss added inline comments.Dec 28 2015, 2:25 PM
messageviewer/src/viewer/messagepart.cpp
551

QScopedPointer doesn't work here, because the QScopedPointer can't be a return value. And using raw pointers is not nice also.

knauss abandoned this revision.Feb 9 2016, 6:09 PM
knauss marked 2 inline comments as done.

commited with b5ac07eb88bdcf14aa9812b16fdf3d4c6d56e539

Revision Contents
Changeset List

Diff 1633

View Options

messageviewer/src/viewer/messagepart.h

Loading...
View Options

messageviewer/src/viewer/messagepart.cpp

Loading...
View Options

messageviewer/src/viewer/objecttreeparser.cpp

Loading...