move html creation at the end of the chain.
ClosedPublic

Authored by knauss on Dec 27 2015, 1:47 PM.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 1632.Dec 27 2015, 1:47 PM
knauss retitled this revision from to move html creation at the end of the chain..
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: vkrause.
knauss set the repository for this revision to R43 KDE PIM.
knauss added a project: KDE PIM.
dvratil added inline comments.
messageviewer/src/viewer/messagepart.cpp
575

You can use mp.dynamicCast<MessagePart>() ;-)

679–680

Is it possible that messageParts() ever returns an empty list? Also, you can use messageParts().last().staticCast<MessagePart>() as well ;-)

757

This operation does not look very const to me

knauss added inline comments.Dec 28 2015, 1:12 PM
messageviewer/src/viewer/messagepart.cpp
679–680

no massageParts can't be empty because it is filled in the if block above, and the else block has a continue, so only if something was added it gets to this line.

757

well - but it is const in terms of the object itself. But yes the contrain why I made it const is gone in meanwhile - so it is better to mak it as const.

messageviewer/src/viewer/objecttreeparser.cpp
405

delete newline

This revision was automatically updated to reflect the committed changes.