Details
Details
- Reviewers
vkrause - Group Reviewers
KDE PIM - Maniphest Tasks
- T719: Refactor objecttreeparser
- Commits
- R94:eb1cb8402665: Move attachment logic into MessagePart
Diff Detail
Diff Detail
- Repository
- R94 PIM: Message Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
messageviewer/src/viewer/messagepart.h | ||
---|---|---|
179 | I don't see this called anywhere with attachment = false, so maybe you could omit the argument, rename it to setAttachmentNode() and only take attachmentNode argument? Then you can just check if mAttachmentNode is non-null to determine whether you have an attachment or not? |
messageviewer/src/viewer/messagepart.h | ||
---|---|---|
179 | get rid of mAttachment: +1 but renaming is not a good idea,because it is not a attachmentNode of the messagepart - isAttachment is a property of the messagePart itself. So I thing renaming it to setAttachmentNode soulds like, it is a attachmentNode of the messagepart. |