Create ~/.local/share/adblock/ if it doesn't exist
ClosedPublic

Authored by wbauer on Jul 29 2017, 10:10 PM.

Details

Summary

Otherwise saving manual filters will fail, which will also result in the general settings (Enable Ad Block, Hide filtered elements, Update interval) not getting written at all.

Test Plan

Run Akregator or KMail on a fresh user account or delete ~/.local/share/adblock/ before you run it.
Enable the options "Enable Ad Block" and/or "Hide filtered elements" in the Adblock plugin settings (or disable them if they are already on) and click OK.
Quit and restart Akregator/KMail.

The settings are remembered now, before they were reverted again.

Also, adding custom manual filter rules works now and they are remembered.

Debug message "Unable to open rule file /home/xxx/.local/share/adblock/adblockrules_local" disappears too with the patch.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wbauer created this revision.Jul 29 2017, 10:10 PM
mlaurent accepted this revision.Jul 30 2017, 6:20 AM

Hi,
Thanks for this patch.
Please apply it in 17.08 and use git merge for merging it in master.
thanks

This revision is now accepted and ready to land.Jul 30 2017, 6:20 AM
This revision was automatically updated to reflect the committed changes.