changes required for msvc2017, qt-5.9.1 with openssl-linked
Needs ReviewPublic
Actions

Authored by dmantovani on Jul 28 2017, 10:10 PM.

Details

Reviewers

habacker

Summary

I compiled kdewin-installer with msvc2017 and with qt-5.9.1. The compilation is statically linked and works.

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

dmantovani changed the visibility from "Public (No Login Required)" to "No One".Jul 29 2017, 8:00 AM

dmantovani added a reviewer: habacker.

dmantovani changed the visibility from "No One" to "Public (No Login Required)".

Thanks for you effort. Please fix the mentioned issue to get further review.

3rdparty/bzip2/bzip2.c
44	unrelated, please remove
3rdparty/filters/tarfilter.cpp
496	unrelated space/empty line fix. Please remove or merge all non code changes into a spearate patch.
CMakeLists.txt
11	Do not add this because it uses hardcoded pathes. You can set this in CMakeCache.txt
14	unrelated change. Please remove it
52–53	These libraries are only required in static build mode. Please move them to the location where STATIC_BUILD == TRUE is handled
53	unrelated, please remove
53	You removed qt5main, is it move required ?
57	This loop looks no functional because _loc is never used. Please remove
119–120	This does not change anything. Please exclude from patch
269	Why are you don't using OPENSSL_LIBRARIES ?
281	Why adding this import library ? Should it not be named simply 'version' ? Is this library always available ? if not it should be limited to the related compiler version
286	Using REQUIRED breaks any build using other Qt versions. If this is required for Qt 5.9 limit it to the required Qt version
tests/CMakeLists.txt
1	You removed this unrelated file. Please exclude from patch

Dear Ralf,

I'm working on these issues. I shall let you know as soon as the fix is complete.

Dear Ralf,

I changed the code as indicated in your email. Please have another look and let me know if the code is satisfactory.

Cheers,

Daniela

Dear Ralf,

the issues that you mentioned should now be fixed. Do you want to continue your review, please?

		Path
M		3rdparty/bzip2/bzip2.c (2 lines)
M		3rdparty/bzip2/bzlib.c (5 lines)
M		3rdparty/filters/tarfilter.cpp (14 lines)
M		3rdparty/quazip/quazip/ioapi.c (4 lines)
M		3rdparty/zlib/gzio.c (4 lines)
M		CMakeLists.txt (103 lines)
M		gui/CMakeLists.txt (30 lines)
M		gui/main.cpp (3 lines)
M		sha1sum/sha1sum.cpp (4 lines)
M		shared/downloader.cpp (1 line)
M		single-package-installer/main.cpp (3 lines)
D	M	tests/CMakeLists.txt (47 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17341	e96b36e		Jul 28 2017, 10:10 PM	★	★
Diff 2	17974	e96b36e	- cleanup general	Aug 10 2017, 5:04 PM	★	★
Diff 3	18077	e96b36e	- further cleanup cmakelists.txt	Aug 13 2017, 9:06 AM	★	★
Diff 4	19066	e96b36e	- patched also single-package-installer/main.cpp for qt5	Sep 1 2017, 4:58 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4f1772e962e3	b288e80f3c5e	47e9eff7ea44	Daniela Mantovani	patched also single-package-installer/main.cpp for qt5	Sep 1 2017, 4:54 PM
47e9eff7ea44	697213b8cd8e	cf77e1605f8c	Daniela Mantovani	further cleanup cmakelists.txt	Aug 13 2017, 9:03 AM
cf77e1605f8c	6186390fbe65	318421c8e485 8fd1d1f15846	Daniela Mantovani	Merge branch 'master' of https://github.com/KDE/kdewin-installer (Show More…)	Aug 8 2017, 8:54 PM
318421c8e485	6186390fbe65	3a886b4e00db	Daniela Mantovani	cleanup general	Aug 8 2017, 8:49 PM
3a886b4e00db	21e67b1d6780	e96b36eeabf3	Daniela Mantovani	changes required for msvc2017, qt-5.9.1 with openssl-linked (Show More…)	Jul 28 2017, 10:02 PM
8fd1d1f15846	34686932b3ba	1a63e5da569a	Ralf Habacker	Revert "Do not depend on openssl if only building packager which does not… (Show More…)	Apr 3 2017, 11:27 AM