More details here: https://bugs.kde.org/show_bug.cgi?id=379930
Details
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
I think it would also be good to remove the line static bool preInitialize(); in kcms/keyboard/xkb_helper.h, because it will be unused.
I'm not sure if I have the right to approve the review (I'm not part of KDE team), but it seems I could do it without any problem.
Yeah, killing input method is not a great idea, not to mention ibus is not the only one messing with keyboard layout. If people really want to know what's messing around I'd rather check the input method's dbus name and throw a warning.
Eike, next time you commit patches from contributors, please use the --author option in git commit to give proper attribution. Additionally, a bug number was given, but BUG: keyword was missing in the commit message.
I used arc patch which usually preserves authorship, I don't know why it didn't this time - I blame the tool. :)