Differential D6943

Gave plasmoid some love
ClosedPublic
Actions

Authored by nicolasfella on Jul 26 2017, 10:19 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:3c3b5b03917f: Gave plasmoid some love
R224:66e5eefe20a6: Gave plasmoid some love
Summary

Make the plasmoid content transparent
Include battery info in header
Only show remotekeyboard input if available
Make header always centered

before:

after:

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 26 2017, 10:19 PM
nicolasfella edited the summary of this revision. (Show Details)
apol added a subscriber: apol.Jul 26 2017, 10:24 PM

LGTM

plasmoid/package/contents/ui/DeviceDelegate.qml
155

Just drop the line

203

Just drop the line

206

Include the : in the translation or leave it like it was.

albertvaka added a subscriber: albertvaka.Jul 26 2017, 10:30 PM

Looks neat! :D

plasmoid/package/contents/ui/DeviceDelegate.qml
108

same as with the ":" after "notifications", try to make all the display text be inside i18n calls.

text: (battery.available && battery.charge > -1) ? i18n("%1 (%2)", display, battery.displayString) : display

jeanv added a subscriber: jeanv.Jul 27 2017, 6:48 AM

I like it! Although I think we should keep the feature of knowing if the phone is charging or not. Just something like:

OnePlus (100%, charging)

or

OnePlus (100% ⇧)

nicolasfella added a comment.Jul 27 2017, 10:38 AM
In D6943#129375, @jeanv wrote:

I like it! Although I think we should keep the feature of knowing if the phone is charging or not. Just something like:

OnePlus (100%, charging)

or

OnePlus (100% ⇧)

Charging ist still there, I just removed discharging because it is not really helpful

apol accepted this revision.Jul 27 2017, 3:00 PM
This revision is now accepted and ready to land.Jul 27 2017, 3:00 PM
Closed by commit R224:66e5eefe20a6: Gave plasmoid some love (authored by nicolasfella). · Explain WhyJul 27 2017, 3:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17295

View Options

plasmoid/package/contents/ui/Battery.qml

Loading...
View Options

plasmoid/package/contents/ui/DeviceDelegate.qml

Loading...