By implementing setData we make the model magic property writable and can directly assign model.checked a new value.
Not only is this cleaner but it will just work with proxy models.
Details
Details
- Reviewers
hein - Group Reviewers
Plasma - Commits
- R119:76af2694e937: [Folder View Config] Make model writable and drop custom setRowChecked method
Changed some preview plugins, applied settings, preview plugins were loaded/unloaded as desired.
Changed some mimetype filters, applied settings, files showed up anddisappeared as desired.
(The FilterableMimeTypesModel can probably be removed and replaced by a Plasma SortFilterModel)
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Emit checkedTypesChanged only when changed, I hoped model would be smart enough not to change if the value was the same but implicit assignment always ends up in setData