This makes the dialog more user-friendly by providing a ComboBox with applications that can handle text/html (typically web browsers) instead of only providing a "guess contents" and "custom command" text field.
Details
Details
- Reviewers
dfaure - Group Reviewers
Plasma VDG - Commits
- R119:4cd9302762c6: [Component Chooser] Add ComboBox with browsers
Before
After
Verified that:
- Checking "in an application based on contents" removes the BrowserApplication from kdeglobals
- Selecting an application from the combo is properly saved and restored
- Entering a custom command is properly saved and restored
- When choosing a custom application (... button) but it is listed in the combobox, the "in the following application" is checked and the appropriate entry in the ComboBox selected
- clicking links in KDE apps actually open in the desired application
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| kcms/componentchooser/componentchooserbrowser.cpp | ||
|---|---|---|
| 85 | One could also instead use KServiceTypeTrader::self()->query(QStringLiteral("Application"), QStringLiteral("'WebBrowser' in Categories"));to really list only web browsers. (I wouldn't mind either), currently it lists all browsers I have plus Kate and Kwrite | |
Comment Actions
Excellent idea.
| kcms/componentchooser/componentchooserbrowser.cpp | ||
|---|---|---|
| 85 | I like this idea, it sounds more user-friendly indeed. | |