Fix path issues in debugger unittests
ClosedPublic
Actions

Authored by qi437103 on Jul 24 2017, 8:18 PM.

Details

Reviewers

apol
kfunk

Group Reviewers

KDevelop

Commits

R32:3adcfd641f56: Fix path issues in debugger unittests

Summary

Debugees and their source files were moved to common folder, but the path finding routines in LLDB/GDB weren't changed.
This patch updates the LLDB testhelpers to handle moved debuggees and shares that between LLDB and GDB, along with a few
other improvements in path handling in unittests.

Test Plan

most LLDB/GDB unit tests pass after the patch, which fail without the patch.

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

qi437103 created this revision.Jul 24 2017, 8:18 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 24 2017, 8:18 PM

qi437103 added a reviewer: KDevelop.Jul 24 2017, 8:19 PM

Thanks for cleaning up!

This revision is now accepted and ready to land.Jul 25 2017, 1:38 PM

Closed by commit R32:3adcfd641f56: Fix path issues in debugger unittests (authored by qi437103). · Explain WhyJul 25 2017, 7:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		debuggers/common/tests/CMakeLists.txt (10 lines)
M		debuggers/common/tests/debuggees/path with space/CMakeLists.txt (4 lines)
M		debuggers/common/tests/debuggers-tests-config.h.in (1 line)
V		debuggers/{common/tests ← lldb/unittests}/testhelper.h (14 lines)
V		debuggers/{common/tests ← lldb/unittests}/testhelper.cpp (23 lines)
M		debuggers/gdb/unittests/CMakeLists.txt (11 lines)
D	M	debuggers/gdb/unittests/debugee space.cpp (23 lines)
D	M	debuggers/gdb/unittests/debugee.cpp (41 lines)
D	M	debuggers/gdb/unittests/debugeecrash.cpp (31 lines)
D	M	debuggers/gdb/unittests/debugeeechoenv.cpp (40 lines)
D	M	debuggers/gdb/unittests/debugeeexception.cpp (37 lines)
D	M	debuggers/gdb/unittests/debugeemultilocbreakpoint.cpp (35 lines)
D	M	debuggers/gdb/unittests/debugeemultiplebreakpoint.cpp (52 lines)
D	M	debuggers/gdb/unittests/debugeeqt.cpp (30 lines)
D	M	debuggers/gdb/unittests/debugeerecursion.cpp (32 lines)
D	M	debuggers/gdb/unittests/debugeeslow.cpp (37 lines)
D	M	debuggers/gdb/unittests/debugeethreads.cpp (42 lines)
D	M	debuggers/gdb/unittests/path with space/CMakeLists.txt (2 lines)
D	M	debuggers/gdb/unittests/path with space/spacedebugee.cpp (31 lines)
M		debuggers/gdb/unittests/test_gdb.cpp (121 lines)
M		debuggers/lldb/unittests/CMakeLists.txt (13 lines)
M		debuggers/lldb/unittests/test_lldb.cpp (83 lines)
M		debuggers/lldb/unittests/test_lldbformatters.cpp (25 lines)
V		debuggers/{lldb/unittests → common/tests}/testhelper.h
V		debuggers/{lldb/unittests → common/tests}/testhelper.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17143	c952918		Jul 24 2017, 8:18 PM	★	★
Diff 2	17185	c952918	R32:3adcfd641f56ce0754ba230cd0af37e2621b1b3c	Jul 25 2017, 7:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
62a0e2982a31	ed39e4ae8c64	8dd6ad27091e	Peifeng Yu	Fix path issues in GDB unittests, which now share debuggees with LLDB.	Jul 24 2017, 8:10 PM
8dd6ad27091e	e816a6854537	1ca135f55b90	Peifeng Yu	Share testhelpers between LLDB and GDB unittests	Jul 24 2017, 7:40 PM
1ca135f55b90	3238f4b8e898	c952918d7aca	Peifeng Yu	Fix path issues in LLDB unittests (Show More…)	Jul 24 2017, 7:15 PM

Fix path issues in debugger unittestsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 17185

debuggers/common/tests/CMakeLists.txt

debuggers/common/tests/debuggees/path with space/CMakeLists.txt

debuggers/common/tests/debuggers-tests-config.h.in

debuggers/common/tests/testhelper.h

debuggers/common/tests/testhelper.cpp

debuggers/gdb/unittests/CMakeLists.txt

debuggers/gdb/unittests/debugee space.cpp

debuggers/gdb/unittests/debugee.cpp

debuggers/gdb/unittests/debugeecrash.cpp

debuggers/gdb/unittests/debugeeechoenv.cpp

debuggers/gdb/unittests/debugeeexception.cpp

debuggers/gdb/unittests/debugeemultilocbreakpoint.cpp

debuggers/gdb/unittests/debugeemultiplebreakpoint.cpp

debuggers/gdb/unittests/debugeeqt.cpp

debuggers/gdb/unittests/debugeerecursion.cpp

debuggers/gdb/unittests/debugeeslow.cpp

debuggers/gdb/unittests/debugeethreads.cpp

debuggers/gdb/unittests/path with space/CMakeLists.txt

debuggers/gdb/unittests/path with space/spacedebugee.cpp

debuggers/gdb/unittests/test_gdb.cpp

debuggers/lldb/unittests/CMakeLists.txt

debuggers/lldb/unittests/test_lldb.cpp

debuggers/lldb/unittests/test_lldbformatters.cpp

debuggers/lldb/unittests/testhelper.h

debuggers/lldb/unittests/testhelper.cpp

Fix path issues in debugger unittests
ClosedPublic
Actions

Revision Contents
Changeset List