Details
Details
Diff Detail
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/lib/marble/MarbleInputHandler.cpp | ||
---|---|---|
944 ↗ | (On Diff #17133) | I think it would be better to check that Qt::ControlModifier is not checked, same below. |
src/lib/marble/MarbleMap.h | ||
688 ↗ | (On Diff #17133) | I'd go for setDebugLevelTag(int) and int debugLevelTag() for consistency |
src/lib/marble/layers/GeometryLayer.cpp | ||
255 ↗ | (On Diff #17133) | layerItems grows large and a cast takes some time, so I'd optimize this a bit for performance: Keep the original loop as-is and add a second one in case d->m_levelTagsDebugModeEnabled is true, sth like if (d->m_levelTagsDebugModeEnabled) { for (auto item: layerItems) { ... } } |
257 ↗ | (On Diff #17133) | Can't we get rid of this check and instead check that the iterator is valid below? |
689 ↗ | (On Diff #17133) | Why not keep the last one? |