Differential D6881

[Folder View] Implement Select All shortcut
ClosedPublic
Actions

Authored by broulik on Jul 24 2017, 3:57 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:ab3ede4f79a0: [Folder View] Implement Select All shortcut
Summary

Pressing Ctrl+A (by default) will select all items.

Test Plan

There's no GUI option for this (but it's also rather hidden in Dolphin) and this is more of a poweruser feature imho anyway.

Pressed Ctrl+A had all Items selected. Verified that an empty folder will not crash this.

(We could theoretically place a "Select All" in the "Icons" context menu, I don't want to clutter the main context menu any further)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 24 2017, 3:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2017, 3:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Aug 24 2017, 3:44 PM

I thought I had written a comment to this, but apparently not - couldn't selectAll just use the existing range select method instead of adding a new one? But then again I'm fine with this too.

hein accepted this revision.Aug 24 2017, 3:44 PM
This revision is now accepted and ready to land.Aug 24 2017, 3:44 PM
broulik updated this revision to Diff 18684.Aug 24 2017, 3:55 PM
  • Use positioner's setRangeSelected
Closed by commit R119:ab3ede4f79a0: [Folder View] Implement Select All shortcut (authored by broulik). · Explain WhyAug 28 2017, 8:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18874

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...