Replace SMTP KIO Slave with KSmtp library
ClosedPublic

Authored by dvratil on Jul 24 2017, 2:46 PM.

Details

Summary

Use KSmtp library from the SMTP mail transport plugin instead of using a complex KIO slave.

Diff Detail

Repository
R84 PIM: KMail Transport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Jul 24 2017, 2:46 PM
mlaurent requested changes to this revision.Jul 24 2017, 3:22 PM

Hi,
make sure that we can send email with several smtp server :)

I will be off tomorrow until friday, so I hope that I will able to accept your patch :)

Regards.

src/kmailtransport/plugins/smtp/autotests/fakeserver.cpp
28

initialize m_tcpServer to nullptr

166

for(...: qAsConst(...))

src/kmailtransport/plugins/smtp/autotests/fakeserver.h
38

Q_decl_override here ?
if necessary replace it by override

41

override

This revision now requires changes to proceed.Jul 24 2017, 3:22 PM
dvratil updated this revision to Diff 17178.Jul 25 2017, 2:27 PM
dvratil edited edge metadata.
  • address Laurent's issues
  • restore option to send custom hostname in EHLO/HELO commands
mlaurent accepted this revision.Jul 27 2017, 5:02 PM

Seems ok for me.

This revision is now accepted and ready to land.Jul 27 2017, 5:02 PM
This revision was automatically updated to reflect the committed changes.