A class derived from QObject should have a cpp file and use Q_OBJECT.
Without that a new class is generated whereever it is used.
Details
Details
- Reviewers
dfaure staniek - Group Reviewers
Calligra: 3.0
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Lint
Lint Skipped - Unit
Unit Tests Skipped
libs/store/KoStoreDevice.h | ||
---|---|---|
39 | See also http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-override |
libs/store/KoStoreDevice.cpp | ||
---|---|---|
22 | Yep. | |
libs/store/KoStoreDevice.h | ||
39 | True. But KDE's default compiler flags for newer compilers can show many warnings for that. Can be cleaned up (https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/) but I would propose not to add new lines with warnings for new code. This way we reduce number of changes globally and get accustomed with current coding standards. |
libs/store/KoStoreDevice.h | ||
---|---|---|
39 | All nice but gcc or clang-tidy is not following this wrt -Wsuggest-override... until then it's academic topic regerding readability :) |
Comment Actions
I've pushed without the override. I do not feel I understand it well enough to commit it.