Differential D6865

Don't access temporary data from QStringBuilder
ClosedPublic
Actions

Authored by ervin on Jul 24 2017, 8:57 AM.

Details

Reviewers
dfaure
bensi
franckarrecot
Commits
R4:54e49fbd7dd1: Don't access temporary data from QStringBuilder
Summary

This was spotted by ASAN, we forgot to force the conversion from
QStringBuilder to QString on fullText.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.Jul 24 2017, 8:57 AM
dfaure accepted this revision.Jul 24 2017, 9:50 AM

Tricky stuff, I guess QStringBuilder "moves" the data to QString upon conversion, and we end up doing that twice...

IMHO this is a case where const QString fullText = ... is easier, but OK :)

This revision is now accepted and ready to land.Jul 24 2017, 9:50 AM
Closed by commit R4:54e49fbd7dd1: Don't access temporary data from QStringBuilder (authored by ervin). · Explain WhyJul 24 2017, 10:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/editorview.cpp (2 lines)

Diff 17093

View Options

src/widgets/editorview.cpp

Loading...