Differential D6864

[System Monitor Applet] Add setting for update interval
ClosedPublic
Actions

Authored by broulik on Jul 24 2017, 8:57 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:2e129f84ce03: [System Monitor Applet] Add setting for update interval
Summary

BUG: 353063
FIXED-IN: 5.11.0

Test Plan

Tested that setting is applied to CPU monitor and opening the dialog restores the value

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 24 2017, 8:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2017, 8:57 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cfeck added a subscriber: cfeck.Jul 31 2017, 10:41 PM
cfeck added inline comments.
applets/systemmonitor/common/contents/config/main.xml
13

Add a "."

applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
115

Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates per second.

broulik added inline comments.Aug 1 2017, 1:13 PM
applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
115

I just did what ksysguard does where a 0 interval pauses updating, for whatever reason this may be useful..

davidedmundson accepted this revision.Apr 24 2018, 2:45 PM
davidedmundson added a subscriber: davidedmundson.

Please add the "." that cfeck said, then ship it

This revision is now accepted and ready to land.Apr 24 2018, 2:45 PM
Closed by commit R120:2e129f84ce03: [System Monitor Applet] Add setting for update interval (authored by broulik). · Explain WhyApr 24 2018, 3:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32983

View Options

applets/systemmonitor/common/contents/config/main.xml

Loading...
View Options

applets/systemmonitor/common/contents/ui/Applet.qml

Loading...
View Options

applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

Loading...