Differential D6841

Use "document-close" as icon for KStandardAction::close
ClosedPublic
Actions

Authored by kossebau on Jul 22 2017, 7:41 PM.

Details

Reviewers
dfaure
Group Reviewers
VDG
Commits
R265:89b36b21701c: Use "document-close" as icon for KStandardAction::close
Summary

As KStandardAction::close is about closing a file/document, both by
API dox ("Close the current document") as well as set tooltip text
("Close document"), the icon should follow this concept closely
(pun intended).
Changing to "document-close" also follows what manually created
actions e.g. in Kate or KDevelop use for this kind of action.

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 22 2017, 7:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 22 2017, 7:41 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Aug 8 2017, 7:19 AM
This revision is now accepted and ready to land.Aug 8 2017, 7:19 AM
Closed by commit R265:89b36b21701c: Use "document-close" as icon for KStandardAction::close (authored by kossebau). · Explain WhyAug 8 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kstandardaction_p.h (2 lines)

Diff 17894

View Options

src/kstandardaction_p.h

Loading...