Use consistent icons & text for the "Close" actions
ClosedPublic

Authored by kossebau on Jul 21 2017, 7:47 PM.

Details

Summary

Consistently use "document-close" icon for close actions.

Actions on view containers were talking about closing "Files",
while actually they only closed the view (which would trigger
closing of the document/file only if this was the last view).
Talking just about "Close" without a target, like in the other
actions, avoids trying to explain this concept, average user
surely expects this, being a common pattern.

Also moving the close actions in the document toolview context menu
at the end, where close actions are usually placed.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 21 2017, 7:47 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 21 2017, 7:47 PM
kfunk accepted this revision.Jul 21 2017, 11:08 PM
kfunk added a subscriber: kfunk.

Good find again, thanks for that polishing! :)

This revision is now accepted and ready to land.Jul 21 2017, 11:08 PM
This revision was automatically updated to reflect the committed changes.