Implement support for window shortcuts for Wayland windows
ClosedPublic
Actions

Authored by graesslin on Jul 21 2017, 6:25 PM.

Details

Reviewers

Group Reviewers

KWin
Plasma

Commits

R108:c29d6093ba9a: Implement support for window shortcuts for Wayland windows

Summary

Moves most of the implementation from Client to AbstractClient, so that
it can be used for both Client and ShellClient. Only the X11 specific
code is kept in Client.

Not yet implemented is updating the window caption.

Unfortunately the testing of this feature showed that setting a window
shortcut is not working on Wayland at all (the Qt widget doesn't properly
catch the shortcut). So this feature is currently only of erm theoretical
use.

Test Plan

Added new test case. No testing in real world as explained.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Jul 21 2017, 6:25 PM

Restricted Application added a project: KWin. · View Herald TranscriptJul 21 2017, 6:25 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

FYI: I figured out why the shortcut dialog does not work. It's an incorrect construction of the QKeyEvent which KWin uses internally and sends to QWindows and various other places. We convert the current key symbol to Qt:: Key and when a modifier key is released that doesn't change and that destroys the logic of the QKeySequenceEdit.

No idea how to fix it yet.

In D6818#127327, @graesslin wrote:

FYI: I figured out why the shortcut dialog does not work. It's an incorrect construction of the QKeyEvent which KWin uses internally and sends to QWindows and various other places. We convert the current key symbol to Qt:: Key and when a modifier key is released that doesn't change and that destroys the logic of the QKeySequenceEdit.

Issue addressed in D6828.

mart accepted this revision.Jul 24 2017, 11:07 AM

This revision is now accepted and ready to land.Jul 24 2017, 11:07 AM

Closed by commit R108:c29d6093ba9a: Implement support for window shortcuts for Wayland windows (authored by graesslin). · Explain WhyJul 25 2017, 5:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.h (10 lines)
M			autotests/integration/globalshortcuts_test.cpp (39 lines)
M			client.h (10 lines)
M			shell_client.h (2 lines)
M			shell_client.cpp (11 lines)
M			useractions.cpp (40 lines)
M			workspace.h (4 lines)
M			workspace.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16980	8cd95b5		Jul 21 2017, 6:25 PM	★	★
Diff 2	17157	ddd957f	R108:c29d6093ba9afc2ec93d24a6854c81bac1cd3563	Jul 25 2017, 5:12 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
7289853549bc	3fa819e0b338	8cd95b56e3f3	Martin Flöser	Implement support for window shortcuts for Wayland windows (Show More…)	Jul 21 2017, 6:22 PM

	Status	Author	Revision
	Closed	graesslin	D6828 Send QKeyEvent with Qt::Key as expected by Qt to internal windows
	Closed	graesslin	D6818 Implement support for window shortcuts for Wayland windows