Use customized font size for Digital Clock applet
AbandonedPublic

Authored by guoyunhe on Jul 21 2017, 4:23 PM.

Details

Reviewers
None
Group Reviewers
Plasma: Workspaces
Summary

This patch is not tested! I have some trouble to compile or run Plasma Workspace. Hope someone could help me test or give some build/test instruction. :-)

The "Digital Clock" applet uses panel height or applet height to decide the font size. If the panel is 50px high, the "Digital Clock" applet would have a huge font size around 48px. (without date or timezone) This is too big for many users.

In other desktop environment, like Unity, GNOME, Windows, macOS, similar date time applets have fixed font size that equals to the default UI font size.

This patch would add a "Font size" option to appearance configuration dialog.

If not set a font size, it uses "Default", the default font size of Plamsa. If a value was set, it will use the specific font size. It still follow the panel size and applet size limits. So the font size should never be larger than label height.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
guoyunhe created this revision.Jul 21 2017, 4:23 PM
Restricted Application added a project: Plasma. ยท View Herald TranscriptJul 21 2017, 4:23 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald Transcript

Thanks, FYI we've had another review with the same change this week: https://phabricator.kde.org/D6764

There's some comments there.

Thanks, FYI we've had another review with the same change this week: https://phabricator.kde.org/D6764

Good to know ๐Ÿ˜ƒ

Any reasons not to land this or https://phabricator.kde.org/D6764?

guoyunhe abandoned this revision.Sep 16 2019, 12:05 PM

It seems not possible to set font size because others insist the font size should grow with panel. Another alternative widget might be better way to push forward.