Change name of files
ClosedPublic

Authored by laysrodrigues on Jul 21 2017, 3:00 PM.

Details

Summary

GeneralSettingsDialog -> ProfilesDialog
Fits better on this way. Change all the necessary files
to fit to this new name.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Add option to remove a profile

Based on the current profile on the combobox, I remove
it and reload the profiles.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues created this revision.Jul 21 2017, 3:00 PM
rizzitello requested changes to this revision.Jul 21 2017, 8:59 PM

please add an on close event checking if the dialog has changes to the loaded profile and asking to save them .

This revision now requires changes to proceed.Jul 21 2017, 8:59 PM
rizzitello added inline comments.Jul 21 2017, 9:01 PM
src/dialogs/profilesdialog.cpp
82

i18n("A profile with this name already exists. \n Are you sure you want to overwrite it?"),

laysrodrigues added inline comments.Jul 21 2017, 9:04 PM
src/dialogs/profilesdialog.cpp
82

This will cause confusion to the user.

rizzitello added inline comments.Jul 21 2017, 9:15 PM
src/dialogs/profilesdialog.cpp
82

This message is only shown if the user already has a profile with the name when they try to save.

laysrodrigues edited edge metadata.
  • Change name of files
  • Add option to remove a profile
  • Change warning string value
rizzitello requested changes to this revision.Jul 22 2017, 7:00 PM

please add an on close event checking if the dialog has changes to the loaded profile and asking to save them .

This revision now requires changes to proceed.Jul 22 2017, 7:00 PM
laysrodrigues requested review of this revision.Jul 27 2017, 6:03 PM
laysrodrigues edited edge metadata.

Hey sith, I already talked with tomaz and he gave me an idea based on subsurface code that I will check this weekend. Like on this patch I'm only handling the change of name of the dialog, your request is not relevant to this patch, but I already have a task open to work on the improvement of save of profiles.
Would you mind to approve it?
Thanks =D

rizzitello accepted this revision.Jul 27 2017, 6:22 PM

be sure to rebase before you merge it . so that it closes correctly in phabricator :D

This revision is now accepted and ready to land.Jul 27 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.