Adds a footer list for imageviewer
ClosedPublic

Authored by atulsharma on Jul 21 2017, 1:48 PM.

Details

Summary

Refs T6268

  • Shows the list of more than one images
  • Auto-hides after 2 secs of image change

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulsharma created this revision.Jul 21 2017, 1:48 PM
atulsharma updated this revision to Diff 16969.Jul 21 2017, 2:00 PM

On clicking image in the footer list the currentimage in imageviewer change

atulsharma added inline comments.Jul 21 2017, 2:02 PM
qmlUiKirigami/ImageViewer.qml
337

or should we just remove the highlight
and try to keep the currentItem in the horizontalCenter of the page

atulsharma added inline comments.Jul 21 2017, 2:04 PM
qmlUiKirigami/ImageViewer.qml
337

but not sure how?

atulsharma added inline comments.Jul 21 2017, 3:33 PM
qmlUiKirigami/ImageViewer.qml
338

this breaks the currentIndex change when the main image is changed due to flicking

atulsharma updated this revision to Diff 16981.Jul 21 2017, 7:03 PM

Keeps the currentItem in center of the page

atulsharma marked 3 inline comments as done.Jul 21 2017, 7:04 PM
atulsharma updated this revision to Diff 16996.Jul 22 2017, 3:26 AM

Changing currentIndex in footerList now changes the index
currentIndex does not break now

mart added inline comments.Jul 22 2017, 10:59 AM
qmlUiKirigami/ImageViewer.qml
316

i don't like the image being resized to make space for this. (content should take every available pixel)
i think this should either go over the other item or if stays in the footer, the foother should be an item of 0 height, and this overflowing from it.

by default this shouldn't be visible, perhaps should be shown only when the image changes for few seconds then autohide (or mouse cursor going to bottom margin when in full screen, like an autohide panel)

337

perhaps the highlight could even be an ivisible item, then we could try to abuse preferredhighlightbegin/preferredhighlightend

atulsharma updated this revision to Diff 17057.Jul 23 2017, 1:22 PM

Uses PathView

atulsharma updated this revision to Diff 17058.Jul 23 2017, 1:27 PM

Removes the interactive

atulsharma updated this revision to Diff 17059.Jul 23 2017, 2:09 PM

Adds auto hiding of footerList

atulsharma edited the summary of this revision. (Show Details)Jul 23 2017, 2:11 PM
mart accepted this revision.Jul 23 2017, 4:10 PM
This revision is now accepted and ready to land.Jul 23 2017, 4:10 PM
This revision was automatically updated to reflect the committed changes.