Differential D6801

Replace delegate slots for window shortcut by std::bind expressions
ClosedPublic
Actions

Authored by graesslin on Jul 20 2017, 5:10 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Plasma
Commits
R108:150a0357b4a6: Replace delegate slots for window shortcut by std::bind expressions
Summary

Client had a slot to delay a call when setting up a global shortcut for
the Client. This can be simplified by using a std::bind expression.
Similar the action was connected to a one line lambda which can be
expressed through a std::bind expression as well.

Test Plan

New added auto test still passes

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 20 2017, 5:10 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 20 2017, 5:10 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 21 2017, 10:33 AM
This revision is now accepted and ready to land.Jul 21 2017, 10:33 AM
Closed by commit R108:150a0357b4a6: Replace delegate slots for window shortcut by std::bind expressions (authored by graesslin). · Explain WhyJul 29 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mclient.h (3 lines)
Museractions.cpp (13 lines)

Diff 17358

View Options

client.h

Loading...
View Options

useractions.cpp

Loading...