Apply maximize effect to full screen changes
AbandonedPublic

Authored by broulik on Jul 20 2017, 2:26 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
VDG
Summary

Animates the window also when entering/leaving full screen like it does when maximizing/unmaximizing.

Test Plan
  • Entering and leaving slideshow in Gwenview is now nicely animated
  • Chrome and Firefox are both quite slow repainting the scene when going full screen, leading to a somewhat broken last frame to be transitioned to full (but you can see that when resizing or maximizing them, too..)

The window decoration (dis)appears right away without an animation but that doesn't look too bad since it moves along with the window nicely

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 20 2017, 2:26 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 20 2017, 2:26 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
graesslin edited edge metadata.Jul 20 2017, 6:05 PM

If we do this we need to rename the effect - it is no longer a maximize effect. Otherwise I'm surprised of how little impact it has on the code base.

Would this fix: https://bugs.kde.org/show_bug.cgi?id=382161 ?

I was surprised myself. :)

Would this fix: https://bugs.kde.org/show_bug.cgi?id=382161 ?

I looked at it when I did this, actually, but this particular patch does not help. But since we now have the information we could fix this eventually.

Can we land this? It's a nice little polish change.

broulik abandoned this revision.Jan 2 2018, 12:41 PM

Superseded by D9391

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptJan 2 2018, 12:41 PM