Differential D6782

Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL
ClosedPublic
Actions

Authored by kossebau on Jul 19 2017, 12:49 PM.

Details

Reviewers
kfunk
Group Reviewers
Frameworks
Commits
R244:a675fe908bed: Remove unused init() declaration from…
Summary

Method implementation was removed in b6c7c9b93b8dbb24c4a60e7fe72bb1d561d968a0
so this declaration just adds dead code to the macro expansion.

Test Plan

Unit tests still work, KDevelop (K_PLUGIN_FACTORY_WITH_JSON) still builds
fine.

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jul 19 2017, 12:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 19 2017, 12:49 PM
kfunk accepted this revision.Jul 25 2017, 1:34 PM
This revision is now accepted and ready to land.Jul 25 2017, 1:34 PM
Closed by commit R244:a675fe908bed: Remove unused init() declaration from… (authored by kossebau). · Explain WhyJul 25 2017, 10:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/plugin/kpluginfactory.h (2 lines)

Diff 17190

View Options

src/lib/plugin/kpluginfactory.h

Loading...