Fix labels of DeleteFile/RenameFile actions
ClosedPublic

Authored by elvisangelaccio on Jul 18 2017, 6:00 PM.

Details

Summary

These actions can be applied also to folders, so their user-visible
labels should not explicitly mention "File".

BUG: 382450

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 18 2017, 6:00 PM
cfeck added a subscriber: cfeck.Aug 1 2017, 9:11 PM

Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete File" in the context menu, but I do not see "Rename File", but "Rename ..." instead. Does Dolphin not use standard actions consistently?

+1 from my side.

In D6774#131083, @cfeck wrote:

Interesting. When I RMB-click on a folder in Dolphin, I indeed see "Delete File" in the context menu, but I do not see "Rename File", but "Rename ..." instead. Does Dolphin not use standard actions consistently?

Correct, the RenameFile standard action is quite new (@since 5.25) and dolphin doesn't use it yet (see D6777, which depends on this patch).

dfaure accepted this revision.Aug 8 2017, 7:17 AM
dfaure added a subscriber: dfaure.

Is it possible to document somewhere that DeleteFile/RenameFile can be about files and folders?

(I wonder if they shouldn't have been just called Delete and Rename, in fact... it sounds like they could apply to any other type of object too, the icon looks generic)

This revision is now accepted and ready to land.Aug 8 2017, 7:17 AM
  • Add documentation
This revision was automatically updated to reflect the committed changes.