Differential D6771

Fix finding Python scripts
ClosedPublic
Actions

Authored by alvinhochun on Jul 18 2017, 1:58 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:2883eb5bf4cc: Fix finding Python scripts
Summary

KoResourcePaths::findResource("appdata", rel_path) is probably not what we want here as it most certainly didn't work on Windows. I'm not sure how it worked on Linux though.

I changed it to KoResourcePaths::findResource("pythonscripts", rel_path) by a bit of guessing. It does work on Windows, but I don't know if it would break Linux.

Test Plan

On Linux:

  1. Confirm that Python scripts can be found when built from master.
  2. Apply patch on master and rebuild.
  3. Check whether Python scripts can still be found.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alvinhochun created this revision.Jul 18 2017, 1:58 PM
rempt accepted this revision.Jul 18 2017, 2:13 PM
rempt added a subscriber: rempt.

Works fine on Linux!

This revision is now accepted and ready to land.Jul 18 2017, 2:13 PM
Closed by commit R37:2883eb5bf4cc: Fix finding Python scripts (authored by alvinhochun). · Explain WhyJul 18 2017, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16871

View Options

plugins/extensions/pykrita/plugin/engine.cpp

Loading...