Clean up KReportUnit
ClosedPublic

Authored by staniek on Jul 17 2017, 4:14 PM.

Details

Summary
  • remove KReportUnit::ListOption (T4967), add Invalid type, better support descriptions and symbols
  • mark default constants as extern to avoid copying, add DEFAULT_UNIT_TYPE
Test Plan

Build KReport with tests enabled, run tests, run KReportExample, try the Unit combo for the page units.

Build Kexi with this KReport - no changes needed.

(switching units for page is still broken but this is not related to this very patch)

Diff Detail

Repository
R14 KReport
Branch
D6756
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek created this revision.Jul 17 2017, 4:14 PM
Restricted Application added a project: KReport. · View Herald TranscriptJul 17 2017, 4:14 PM
staniek updated this revision to Diff 16835.EditedJul 17 2017, 4:27 PM

Joined commits, updated for master changes

staniek updated this revision to Diff 16841.Jul 17 2017, 6:14 PM

Sync with master

staniek edited the test plan for this revision. (Show Details)Jul 17 2017, 6:26 PM
staniek updated this revision to Diff 16867.Jul 18 2017, 11:49 AM

Port to the new KPropertyListData API

piggz accepted this revision.Jul 20 2017, 6:56 AM
This revision is now accepted and ready to land.Jul 20 2017, 6:56 AM
This revision was automatically updated to reflect the committed changes.