Differential D6746

Fix check for missing engine in comic applet
ClosedPublic
Actions

Authored by davidedmundson on Jul 17 2017, 12:41 AM.

Details

Reviewers
anthonyfieroni
Group Reviewers
Plasma
Commits
R114:8aa47be2abe6: Fix check for missing engine in comic applet
Summary

Current code would check the comic engine was not installed and not create the
download dialog, but would still always try to show it. This would
crash.

BUG: 372313

Test Plan

Code review

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 17 2017, 12:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni accepted this revision.Jul 17 2017, 4:04 AM
This revision is now accepted and ready to land.Jul 17 2017, 4:04 AM
Closed by commit R114:8aa47be2abe6: Fix check for missing engine in comic applet (authored by davidedmundson). · Explain WhyJul 17 2017, 11:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/comic/comic.cpp (5 lines)

Diff 16807

View Options

applets/comic/comic.cpp

Loading...