Differential D6742

Find the intermediate folders for an image
ClosedPublic
Actions

Authored by atulsharma on Jul 16 2017, 6:46 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T6498: commandline image 2) load the intermediate folders

Commits

R659:ed876e0f2ad5: Find the intermediate folders for an image

Summary

Refs T6498

imagePathArgument is now a QStringList and it is passed as it is to the qml

Diff Detail

Repository

R659 Koko Image Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

atulsharma created this revision.Jul 16 2017, 6:46 PM

Pushes the correct item to the pageStack

Calculates the currentIndex for the gridView

made the imagePathArgument a QStringList

atulsharma edited the summary of this revision. (Show Details)Jul 17 2017, 12:22 PM

Removes case check other than PicturesLocation

mart added inline comments.Jul 17 2017, 12:33 PM

src/main.cpp
87	again, coding style: if () { } https://techbase.kde.org/Policies/Kdelibs_Coding_Style
96	just manage the first if, is fine to manage the cases of foreign paths like now

removes foreign path check

mart accepted this revision.Jul 17 2017, 1:27 PM

This revision is now accepted and ready to land.Jul 17 2017, 1:27 PM

Closed by commit R659:ed876e0f2ad5: Find the intermediate folders for an image (authored by atulsharma). · Explain WhyJul 17 2017, 1:29 PM

This revision was automatically updated to reflect the committed changes.

mart added inline comments.Jul 17 2017, 1:56 PM

src/imagefoldermodel.cpp
99	this block should go away

Revision Contents
Changeset List

			Path	Packages
M			qmlUiKirigami/Main.qml (6 lines)
M			src/imagefoldermodel.cpp (12 lines)
M			src/main.cpp (15 lines)

Diff 16818

qmlUiKirigami/Main.qml

Loading...

src/imagefoldermodel.cpp

Loading...

src/main.cpp

Loading...