Differential D6740

Fixed exception while handling notifications
ClosedPublic
Actions

Authored by nicolasfella on Jul 16 2017, 6:23 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:2ffeab0c5e3f: Fixed exception while handling notifications
Summary

An exception occurred while processing non-repliable notifications

Test Plan

Send a non-repliable notification, look in log for exception

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 16 2017, 6:23 PM
albertvaka accepted this revision.Jul 16 2017, 9:17 PM
albertvaka added a subscriber: albertvaka.

Looks good to me.

This revision is now accepted and ready to land.Jul 16 2017, 9:17 PM
apol added a subscriber: apol.Jul 16 2017, 10:55 PM
In D6740#126051, @albertvaka wrote:

Looks good to me.

Remember to merge in the 1.x branch!

Closed by commit R225:2ffeab0c5e3f: Fixed exception while handling notifications (authored by nicolasfella). · Explain WhyJul 17 2017, 1:26 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella added a comment.Jul 17 2017, 1:37 PM

Remember to merge in the 1.x branch!

How do I merge remote branches?

albertvaka added a comment.Jul 20 2017, 2:23 PM

Usually fixes like these go to the '1.x' git branch (so you 'git checkout 1.x' before making to commit), while new feature go to the 'master' branch. When new features are stable enough we merge them back to the 1.x branch to release them. In this case don't worry, because we are close to a release and we will be keeping both branches in sync anyway :)

Revision Contents
Changeset List

Diff 16817

View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

Loading...