[qpa] Use the new OpenGLContextAttributeBuilder to create Qt's OpenGL context
ClosedPublic

Authored by graesslin on Jul 16 2017, 3:33 PM.

Details

Summary

Introduces a few more attributes needed for creating the OpenGL context
used by the QPA.

Test Plan

Extended test and run KWin/Wayland and verified that OpenGL context
gets created correctly.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 16 2017, 3:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 16 2017, 3:33 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jul 16 2017, 4:04 PM
davidedmundson added a subscriber: davidedmundson.

Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually switch contexts.
(I tried for Aurorae on X, it didn't work out, but I can't remember why)

This revision is now accepted and ready to land.Jul 16 2017, 4:04 PM

Sort of offtopic: are you aware of the new(ish) QOpenGLContext::setNativeHandle() theoretically we can just wrap kwin's existing OpenGL context and not have to actually switch contexts.
(I tried for Aurorae on X, it didn't work out, but I can't remember why)

KWin's context is not good enough for QtQuick. We don't have a stencil buffer. And in the other direction QtQuick's context is not good enough for KWin as it is not using the robustness extension.

This revision was automatically updated to reflect the committed changes.