Icons with style
ClosedPublic

Authored by rizzitello on Jul 15 2017, 12:48 PM.

Details

Summary
  • Use the systems style hints to provide some icons. Before we were only using fromTheme to get the icons from the system.

It turns out that we can pull some icons on any platform using QStyle. I have done this for the ones that have a QStyle version.

  • Set Atelier Application Icon
Test Plan

Tested on platforms:
✔ Linux
✔ Windows
✔ Mac Os

Not sure if this also works on Android or BSDs.

Diff Detail

Repository
R231 Atelier
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jul 15 2017, 12:48 PM
rizzitello edited the summary of this revision. (Show Details)Jul 15 2017, 12:52 PM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a subscriber: Atelier.
rizzitello updated this revision to Diff 16783.Jul 16 2017, 6:12 PM
  • Set up Program icon T6436
rizzitello edited the summary of this revision. (Show Details)Jul 16 2017, 6:14 PM
laysrodrigues requested changes to this revision.Jul 17 2017, 10:48 AM
laysrodrigues added inline comments.
src/CMakeLists.txt
7 ↗(On Diff #16783)

You dont need this, you can set this variable: set(CMAKE_AUTORCC ON)
And will automatically add qrc files.

This revision now requires changes to proceed.Jul 17 2017, 10:48 AM
rizzitello updated this revision to Diff 16848.Jul 17 2017, 9:12 PM
rizzitello edited edge metadata.
rizzitello edited the summary of this revision. (Show Details)
  • Use style()->standardIcons for the icons we can to provide them crossplatfom.
  • Set up Program icon, and qrc for non stock icons on not linux
rizzitello marked an inline comment as done.Jul 17 2017, 9:12 PM
laysrodrigues accepted this revision.Jul 18 2017, 2:24 PM
This revision is now accepted and ready to land.Jul 18 2017, 2:24 PM
rizzitello updated this revision to Diff 16890.Jul 18 2017, 8:17 PM
  • Use style()->standardIcons for the icons we can to provide them crossplatfom.
  • Set up Program icon, and qrc for non stock icons on not linux
This revision was automatically updated to reflect the committed changes.