Differential D6710

Clean build warning
ClosedPublic
Actions

Authored by rizzitello on Jul 15 2017, 11:51 AM.

Details

Reviewers
laysrodrigues
patrickelectric
tcanabrava
Commits
R232:0522695cab66: Change AtCore::emergencyStop() to use if clause in place of switch to remove…
Summary

AtCore::emergencyStop uses if instead of switch. The switch was single case and had an intentional fallthu in its case down to default. This created a compiler warning about a possible unintended fallthru. We no have a completely clean build with no warnings from the compiler.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jul 15 2017, 11:51 AM
rizzitello edited the summary of this revision. (Show Details)Jul 15 2017, 11:55 AM
rizzitello added reviewers: laysrodrigues, patrickelectric, tcanabrava.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
patrickelectric accepted this revision.Jul 15 2017, 1:09 PM
This revision is now accepted and ready to land.Jul 15 2017, 1:09 PM
Closed by commit R232:0522695cab66: Change AtCore::emergencyStop() to use if clause in place of switch to remove… (authored by rizzitello). · Explain WhyJul 15 2017, 5:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.cpp (8 lines)

Diff 16750

View Options

src/atcore.cpp

Loading...