Properly swap the quick tile side when pressing the shortcut again
ClosedPublic

Authored by graesslin on Jul 15 2017, 7:00 AM.

Details

Summary

The quick tile shortcuts have a feature of moving the window to the next
screen if one presses the same shortcut again.
E.g. if a window is quick tiled to the left on the right most screen,
quick tile again to left should move it to the left screen and quick tile
right. Thus it swaps the borders.

This wasn't handled correctly, especially not for modes like top and
bottom. If a window is quick tiled to the top an impossible mode was
generated: Left | Right. Doesn't make sense.

This change fixes the mode swapping and extends our quick tile testing
to cover the situation.

BUG: 382313
FIXED-IN: 5.10.4

Test Plan

Extended test case

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Jul 15 2017, 7:00 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 15 2017, 7:00 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jul 17 2017, 12:41 PM
This revision is now accepted and ready to land.Jul 17 2017, 12:41 PM
This revision was automatically updated to reflect the committed changes.