Differential D6689

CMake code completion: Add missing chars to be escaped
ClosedPublic
Actions

Authored by geetamc on Jul 13 2017, 5:36 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:db14d0e4989e: CMake code completion: Add missing chars to be escaped
Summary

List of chars to be escaped is taken from: https://cmake.org/Wiki/CMake/Language_Syntax

To use literally any of "()#$^, escape the character with a backslash

Test Plan

created a file foo"()#$^.cpp, the chars are escaped properly.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
geetamc created this revision.Jul 13 2017, 5:36 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 13 2017, 5:36 PM
kfunk accepted this revision.Jul 13 2017, 7:50 PM
This revision is now accepted and ready to land.Jul 13 2017, 7:50 PM
kfunk updated this revision to Diff 16675.Jul 13 2017, 7:55 PM
kfunk edited the summary of this revision. (Show Details)

Simplified code a bit

Closed by commit R32:db14d0e4989e: CMake code completion: Add missing chars to be escaped (authored by geetamc, committed by kfunk). · Explain WhyJul 13 2017, 7:57 PM
This revision was automatically updated to reflect the committed changes.
kfunk added a comment.Jul 13 2017, 7:58 PM

Thanks for the patches, Geetam.

I encourage you to start using Arcanist to upload the patches as that will a) make reviewing the patches easier (because there's "context" in the diff view), b) add proper author information to the Phab Diff.

Please see: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

geetamc added a comment.Jul 13 2017, 8:32 PM
In D6689#125180, @kfunk wrote:

Thanks for the patches, Geetam.

I encourage you to start using Arcanist to upload the patches as that will a) make reviewing the patches easier (because there's "context" in the diff view), b) add proper author information to the Phab Diff.

Please see: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

Oh, I wasn't aware of that, will use arcanist from now on!

Revision Contents
Changeset List

Diff 16667

View Options

projectmanagers/cmake/cmakecodecompletionmodel.cpp

Loading...