use an initializer list instead of calling insert a million times
ClosedPublic
Actions

Authored by sitter on Jul 13 2017, 10:09 AM.

Details

Reviewers

mpyne
kfunk

Commits

Summary

looks nicer, is probably also more optimized, and allows us to tag the
dict as const.

Test Plan

builds and kaboutdatatest passes

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

kfunk added a subscriber: kfunk.

kfunk added inline comments.

src/lib/kaboutdata.cpp
352–370	While at it: `ldict` -> `licenseDict`?

This revision is now accepted and ready to land.Jul 13 2017, 10:29 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/kaboutdata.cpp (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16635	b8cb28b		Jul 13 2017, 10:09 AM	★	★
Diff 2	16638	b8cb28b	R244:30b735056fa2e62d2efc0ec8e9618196d259bf54	Jul 13 2017, 10:43 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
0dfcbdb3ae6c	e7debab9dc41	b8cb28bcd070	Harald Sitter	use an initializer list instead of calling insert a million times (Show More…)	Jul 13 2017, 10:08 AM