Allow non-scalar constants in PHP language support
ClosedPublic

Authored by mtijink on Jul 13 2017, 8:51 AM.

Details

Summary

Newer PHP versions allow almost any expression in the definition of a constant, as long as it is actually constant. This is hard to test in the parser (and impossibly in the grammar definition) though, so this diff just allows any expression.

Test Plan

I edited some tests to make sure the new behaviour is allowed.

Diff Detail

Repository
R52 KDevelop: PHP Support
Lint
Lint Skipped
Unit
Unit Tests Skipped
mtijink created this revision.Jul 13 2017, 8:51 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 13 2017, 8:51 AM
zhigalin accepted this revision.Jul 17 2017, 7:56 AM
zhigalin added a subscriber: zhigalin.

Looks good, thanks for your work!

This revision is now accepted and ready to land.Jul 17 2017, 7:56 AM
This revision was automatically updated to reflect the committed changes.