Opens the koko application with the folder containing the image( passed via command line arguments)
ClosedPublic

Authored by atulsharma on Jul 13 2017, 7:03 AM.

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulsharma created this revision.Jul 13 2017, 7:03 AM
mart requested changes to this revision.Jul 13 2017, 7:50 AM
mart added inline comments.
src/imagefoldermodel.cpp
82

i think this method and setUrl are redundant, they can be merged into a single method

src/main.cpp
65

you are still accessing positionalArguments().first() without checking it exists, this will crash

100

the check on positionalarguments is useless here now, as you access it before and not here

This revision now requires changes to proceed.Jul 13 2017, 7:50 AM
atulsharma edited edge metadata.

Removes the imagePathArg property from ImageFolderModel

mart accepted this revision.Jul 13 2017, 10:32 AM
This revision is now accepted and ready to land.Jul 13 2017, 10:32 AM
This revision was automatically updated to reflect the committed changes.