Differential D6667

Set real KDevPlatform version on the libraries
ClosedPublic
Actions

Authored by kfunk on Jul 13 2017, 12:57 AM.

Details

Reviewers
ltoscano
jriddell
asturmlechner
maximilianocuria
rdieter
lbeltrame
Commits
R33:3a979f6ae779: Set real KDevPlatform version on the libraries
R32:3a979f6ae779: Set real KDevPlatform version on the libraries
Summary

Problem *before* this patch: On macOS, KDevPlatform libs showed up like
this in otool -L:

.../libKDevPlatformUtil.10.dylib (compatibility version 10.0.0, current version 10.0.0)

Compare to KF5 libs:

.../libKF5ItemModels.5.dylib (compatibility version 5.0.0, current version 5.33.0)

We'd like to have '5.2.0' as 'current version' instead.

Note: This doesn't have an effect on the SONAME of the library, so
should be harmless from a packaging point of view

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Jul 13 2017, 12:57 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 13 2017, 12:57 AM
kfunk added a reviewer: ltoscano.Jul 13 2017, 12:57 AM

@ltoscano That's okay from a packaging point of view, correct?

kfunk edited the summary of this revision. (Show Details)Jul 13 2017, 12:38 PM
ltoscano added reviewers: jriddell, asturmlechner, maximilianocuria, rdieter, lbeltrame.Jul 13 2017, 12:47 PM
ltoscano edited edge metadata.

Adding few people who are more expert than me

lbeltrame edited edge metadata.Jul 13 2017, 1:31 PM

Does the actual file name change? If so, I fear we might get some breakage.

lbeltrame added a comment.Jul 13 2017, 1:33 PM

On second thought, and look (and discussion with people more knowledgeable than me), it shouldn't, instead (kdevplatform doesn't use symbol versioning).

kfunk added a comment.EditedJul 13 2017, 1:54 PM
In D6667#124997, @lbeltrame wrote:

Does the actual file name change? If so, I fear we might get some breakage.

Doesn't change. It's still e.g. ./shell/libKDevPlatformShell.so.10.0.0

kfunk added a comment.Jul 13 2017, 8:19 PM

Okay, I think this can go in then.

Closed by commit R33:3a979f6ae779: Set real KDevPlatform version on the libraries (authored by kfunk). · Explain WhyJul 13 2017, 8:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16677

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/KDevPlatformMacros.cmake

Loading...