Differential D6666

Allow having a header in a ListView that is in an OverlaySheet
ClosedPublic
Actions

Authored by apol on Jul 13 2017, 12:46 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:868d61272b2a: Allow having a header in a ListView that is in an OverlaySheet
Summary

For some reason when there's a header ListView decides to start the items at 0
and the headerItem is placed in the negative space. This makes it odd when we
add anything on the header.
This patch detects the size of the header and compensates it.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 13 2017, 12:46 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 13 2017, 12:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a comment.Jul 13 2017, 12:50 AM

Before

After

apol updated this revision to Diff 16615.Jul 13 2017, 12:51 AM

Check if there's a flickableItem like others

mart accepted this revision.Jul 13 2017, 7:37 AM
This revision is now accepted and ready to land.Jul 13 2017, 7:37 AM
Closed by commit R169:868d61272b2a: Allow having a header in a ListView that is in an OverlaySheet (authored by apol). · Explain WhyJul 13 2017, 10:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16639

View Options

src/controls/templates/OverlaySheet.qml

Loading...