Add RectF editor, improve grid display, and support translated/untranslated values
ClosedPublic
Actions

Authored by staniek on Dec 17 2015, 11:55 PM.

Details

Reviewers

Commits

R13:d11bfa8afe2b: Add RectF editor, improve grid display, and support translated/untranslated…
R13:98dba6fa116f: Add RectF editor, improve grid display, and support translated/untranslated…

Summary

extensively use current QLocale for displaying values; use C locale for internal representation of values
- separate translated from non-translated API for obtaining value strings
improve indentations and borders of combo, cursor, linestyle editors for various QStyles
assume that invalid grid color means "no grid" for the editor view
improve display of editors for when editor view's grid is off
redraw the view when changing grid settings
build color combo delegate even if KPROPERTY_KF is OFF
add RectF editor
temporarily use int spinbox editor for (u)longlong and uint types
linestyle combo: improve drawing line previews
font editor: properly use the current font when showing the font dialog
kpropertyexample app:
- add test for precision of floating-point numbers
- fix font face
- add "Show grid" and "Show frame" check boxes for testing changes of grid and frame settings

Test Plan

run the kpropertyexample app using various QStyles, test all editors
look at the new APIs

Diff Detail

Repository

R13 KProperty

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

staniek updated this revision to Diff 1549.Dec 17 2015, 11:55 PM

staniek retitled this revision from to Add RectF editor, improve grid display, and support translated/untranslated values.

staniek updated this object.

staniek edited the test plan for this revision. (Show Details)

staniek added a reviewer: piggz.

staniek added a subscriber: Kexi-Devel-list.

staniek added a project: KProperty.Dec 17 2015, 11:55 PM

Hint: Switch to a 665-staniek branch to get the code

Closed by commit R13:98dba6fa116f: Add RectF editor, improve grid display, and support translated/untranslated… (authored by staniek). · Explain WhyDec 18 2015, 12:17 AM

This revision was automatically updated to reflect the committed changes.

Reopening because phab fired autoclose from a feature branch and it should not.

Tested using kproperty example. The expanded RectF shows the correct values, but the summary version shows Int values

Fix RectF editor - QRectF should be used

the diff between the last 2 revisions looks wrong

src/KPropertyEditorView.cpp
214	can this fail? if it cant, then no-need for below if (w) ?

piggz added inline comments.Dec 23 2015, 9:59 AM

src/editors/linestyleedit.cpp
42	should we hard-code styles? what if they change in the future?

Closed by commit R13:d11bfa8afe2b: Add RectF editor, improve grid display, and support translated/untranslated… (authored by staniek). · Explain WhyDec 24 2015, 12:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			examples/window.h (10 lines)
M			examples/window.cpp (40 lines)
M			src/CMakeLists.txt (9 lines)
M			src/KDefaultPropertyFactory.cpp (20 lines)
P			src/KPropertyCoreUtils.cpp (37 lines) Copied from src/KPropertyUtils.h
P			src/KPropertyCoreUtils_p.h (13 lines) Copied from src/KPropertyUtils_p.h
M			src/KPropertyEditorDataModel.cpp (2 lines)
M			src/KPropertyEditorView.h (2 lines)
M			src/KPropertyEditorView.cpp (34 lines)
M			src/KPropertyFactory.h (51 lines)
M			src/KPropertyFactory.cpp (97 lines)
M			src/KPropertyLineStyleItemDelegate_p.h (5 lines)
M			src/KPropertyLineStyleItemDelegate_p.cpp (53 lines)
M			src/KPropertyLineStyleModel_p.cpp (2 lines)
M			src/KPropertyLineStyleSelector_p.h (1 line)
M			src/KPropertyLineStyleSelector_p.cpp (14 lines)
P			src/KPropertyUtils.h (2 lines) Copied to src/KPropertyCoreUtils.cpp
M			src/KPropertyUtils.cpp (13 lines)
P			src/KPropertyUtils_p.h (8 lines) Copied to src/KPropertyCoreUtils_p.h
M			src/KPropertyWidgetsFactory.h (49 lines)
M			src/KPropertyWidgetsFactory.cpp (132 lines)
M			src/editors/CMakeLists.txt (8 lines)
P			src/editors/KPropertyRectFEditor.h (19 lines) Copied from src/editors/rectedit.h
P			src/editors/KPropertyRectFEditor.cpp (57 lines) Copied from src/editors/rectedit.cpp
M			src/editors/KPropertyStringEditor.h (9 lines)
M			src/editors/KPropertyStringEditor.cpp (14 lines)
M			src/editors/booledit.h (12 lines)
M			src/editors/booledit.cpp (76 lines)
M			src/editors/coloredit.h (10 lines)
M			src/editors/coloredit.cpp (43 lines)
M			src/editors/combobox.h (8 lines)
M			src/editors/combobox.cpp (55 lines)
M			src/editors/cursoredit.h (7 lines)
M			src/editors/cursoredit.cpp (39 lines)
M			src/editors/dateedit.h (9 lines)
M			src/editors/dateedit.cpp (10 lines)
M			src/editors/datetimeedit.h (9 lines)
M			src/editors/datetimeedit.cpp (12 lines)
M			src/editors/fontedit.h (13 lines)
M			src/editors/fontedit.cpp (49 lines)
M			src/editors/linestyleedit.h (7 lines)
M			src/editors/linestyleedit.cpp (51 lines)
M			src/editors/pixmapedit.h (9 lines)
M			src/editors/pixmapedit.cpp (38 lines)
M			src/editors/pointedit.h (9 lines)
M			src/editors/pointedit.cpp (23 lines)
M			src/editors/pointfedit.h (9 lines)
M			src/editors/pointfedit.cpp (23 lines)
P			src/editors/rectedit.h (9 lines) Copied to src/editors/KPropertyRectFEditor.h
P			src/editors/rectedit.cpp (27 lines) Copied to src/editors/KPropertyRectFEditor.cpp
M			src/editors/sizeedit.h (9 lines)
M			src/editors/sizeedit.cpp (23 lines)
M			src/editors/sizefedit.h (9 lines)
M			src/editors/sizefedit.cpp (23 lines)
M			src/editors/sizepolicyedit.h (8 lines)
M			src/editors/sizepolicyedit.cpp (23 lines)
M			src/editors/spinbox.h (14 lines)
M			src/editors/spinbox.cpp (52 lines)
M			src/editors/timeedit.h (9 lines)
M			src/editors/timeedit.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1549	d56549a		Dec 17 2015, 11:55 PM	★	★
Diff 2	1550	d56549a	Commit rKPROPERTY98dba6fa116f11c0676d190aa5db3209825fe4ff	Dec 17 2015, 11:51 PM	★	★
Diff 3	1579			Dec 23 2015, 9:49 AM	★	★
Diff 4	1613	d56549a	Commit rKPROPERTYd11bfa8afe2b277a81cb8a9d9955a6b664de8e69	Dec 24 2015, 11:55 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
867323a82470	de077dd47b65	d56549a9d7f6	Jaroslaw Staniek	Add RectF editor, improve grid display, and support translated/untranslated… (Show More…)	Dec 17 2015, 11:41 PM