In D6291 a small naming mistake led to Wayland session with logind not working anymore. Patch to make it work again.
Details
- Reviewers
graesslin - Group Reviewers
KWin - Commits
- R108:a49ba5054f81: [logind] Correct property name to fix logind session
Diff Detail
- Repository
- R108 KWin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
logind.cpp | ||
---|---|---|
67 | Should the variable also be named Active? |
logind.cpp | ||
---|---|---|
67 | Yea, thought about it. It was probably called s_login1ActivateProperty for now because in the ConsoleKit case it has the value "activate". But IMO calling it s_login1ActiveProperty as you proposed would make more sense because the variable/value describes a status. I can change it if others (@erickoegel?) think the same. Either with this diff or in a seperate one. |
Oh wow, yes the property for logind is "Active" and in ConsoleKit2 "active". My brain must have gone out to lunch there when cleaning up the diff to submit it. So s_login1ActiveProperty/s_ck2ActiveProperty makes sense. Sorry about that.
That means my session worked again for at least a week! Wohoo the stability starts to reach the state of Pre-Qt 5.9
logind.cpp | ||
---|---|---|
75 | Does this need to be changed, too? |
logind.cpp | ||
---|---|---|
75 | Yes, it should be "active" as well. Sorry about that. |
logind.cpp | ||
---|---|---|
217 | is this will be Active or Activate |
logind.cpp | ||
---|---|---|
75 | I pushed https://commits.kde.org/kwin/58322c277892942f5ab5128d2e864fb8547157c9 for this. Please verify. |
logind.cpp | ||
---|---|---|
217 | Activate should be right here. Here it's an action (to "Activate" the session) and not a status (is the session currently "Active"?). |
logind.cpp | ||
---|---|---|
75 | That's correct, thanks! |