Differential D6653

[Notifications] Check for corona to avoid crash
ClosedPublic
Actions

Authored by broulik on Jul 12 2017, 3:58 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:8a05294e5b3e: [Notifications] Check for corona to avoid crash
Summary

My previous attempt only fixed the case when notifications were directly in a panel. Now it also no longer crashes when removing a panel that has a System Tray with the notifications applet in it.

BUG: 378508
FIXED-IN: 5.10.4

Test Plan

Created an empty panel, placed a system tray inside, removed the panel. No longer crashes.
Verified that resizing the panel properly repositions the notification popups.

5.8 branch?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 12 2017, 3:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 12 2017, 3:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jul 12 2017, 3:59 PM
mart accepted this revision.Jul 12 2017, 4:01 PM
This revision is now accepted and ready to land.Jul 12 2017, 4:01 PM
Closed by commit R120:8a05294e5b3e: [Notifications] Check for corona to avoid crash (authored by broulik). · Explain WhyJul 12 2017, 4:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16593

View Options

applets/notifications/lib/notificationsapplet.cpp

Loading...