Differential D6626

Session file parser: Support sections and respect the Hidden property
ClosedPublic
Actions

Authored by fvogt on Jul 11 2017, 11:08 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R123:65dc9de7c45d: Session file parser: Support sections and respect the Hidden property
R123:992143c4bf5a: Session file parser: Support sections and respect the Hidden property
Summary

Some desktop files have multiple sections, but for now we're only
interested in [Desktop Entry]. Without this patch, every entry was seen
as part of the [Desktop Entry] session, resulting in values getting
overwritten.

Additionally, the Hidden=true property specifies that the desktop file
needs to be treated like it was non-existant.

Same as https://github.com/sddm/sddm/pull/821 for sddm.

BUG: 381982

Test Plan

Installed the KCM, now there are no duplicate sessions and the right
Name is shown for icewm-session.desktop.

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jul 11 2017, 11:08 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2017, 11:08 AM
davidedmundson accepted this revision.Jul 11 2017, 11:12 AM
davidedmundson added a subscriber: davidedmundson.

We should just port this back to KConfig / QSettings sometime.

This revision is now accepted and ready to land.Jul 11 2017, 11:12 AM
Closed by commit R123:992143c4bf5a: Session file parser: Support sections and respect the Hidden property (authored by fvogt). · Explain WhyJul 11 2017, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/sessionmodel.cpp (22 lines)

Diff 16506

View Options

src/sessionmodel.cpp

Loading...