Differential D6615

Simplify Alternatives Dialog code
ClosedPublic
Actions

Authored by davidedmundson on Jul 10 2017, 9:16 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:c32548441d97: Simplify Alternatives Dialog code
Summary

Replace QObject::sender() and tracking objects in a list with a simple lambda.

Test Plan

Opened and closed dialog.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jul 10 2017, 9:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 10 2017, 9:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson updated this revision to Diff 16480.Jul 10 2017, 9:56 PM

Simplify another line

mart accepted this revision.Jul 11 2017, 9:40 AM
This revision is now accepted and ready to land.Jul 11 2017, 9:40 AM
Closed by commit R120:c32548441d97: Simplify Alternatives Dialog code (authored by davidedmundson). · Explain WhyJul 11 2017, 12:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.h (2 lines)
Mshell/shellcorona.cpp (44 lines)

Diff 16514

View Options

shell/shellcorona.h

Loading...
View Options

shell/shellcorona.cpp

Loading...