Details

Reviewers

mart

Group Reviewers

Koko

Maniphest Tasks

T6268: Implementing the main ImageViewer

Commits

R659:18e96d3f7cae: Applies filter to just show the images in the ImageViewer

Summary

adds SortModel in ImageViewer to filter just the images for the ImageViewer listView
uses filterRole and filterRegExp properties exposed by QSortFilterProxyModel
mapping from source and to source are done in order to keep the currentItem consistent for every view

Diff Detail

Repository

R659 Koko Image Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

atulsharma created this revision.Jul 10 2017, 1:17 PM

atulsharma added a task: T6268: Implementing the main ImageViewer.Jul 10 2017, 1:20 PM

currentImage stores the information related to the source model

mart added inline comments.Jul 10 2017, 3:25 PM

src/sortmodel.cpp
243	return mapFromSource( sourceModel()->index( indexValue, 0, QModelIndex())).row();

Mapping

adds mappings

Adds MimeTypeRole definition for ImageListModel

view of currentImage automatically changes the currentItem according to the navigation performed in imageviewer

atulsharma edited the summary of this revision. (Show Details)Jul 11 2017, 8:44 AM

mart accepted this revision.Jul 11 2017, 8:46 AM

This revision is now accepted and ready to land.Jul 11 2017, 8:46 AM

Closed by commit R659:18e96d3f7cae: Applies filter to just show the images in the ImageViewer (authored by atulsharma). · Explain WhyJul 11 2017, 8:47 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			qmlUiKirigami/AlbumDelegate.qml (2 lines)
M			qmlUiKirigami/AlbumView.qml (2 lines)
M			qmlUiKirigami/ImageViewer.qml (25 lines)
M			qmlUiKirigami/main.qml (13 lines)
M			src/imagelistmodel.h (2 lines)
M			src/imagelistmodel.cpp (12 lines)
M			src/qmlplugins.cpp (2 lines)
M			src/roles.h (1 line)
M			src/sortmodel.h (2 lines)
M			src/sortmodel.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16450	1dff4c0		Jul 10 2017, 1:17 PM	★	★
Diff 2	16455	1dff4c0	currentImage stores the information related to the source model	Jul 10 2017, 3:16 PM	★	★
Diff 3	16463	1dff4c0	Mapping	Jul 10 2017, 5:55 PM	★	★
Diff 4	16465	1dff4c0	adds mappings	Jul 10 2017, 6:25 PM	★	★
Diff 5	16468	1dff4c0	Adds MimeTypeRole definition for ImageListModel	Jul 10 2017, 6:48 PM	★	★
Diff 6	16489	4b2903c	view of currentImage automatically changes the currentItem according to the…	Jul 11 2017, 8:38 AM	★	★
Diff 7	16492	e80a422	R659:18e96d3f7cae4c2a46d91918edf52532c5417637	Jul 11 2017, 8:47 AM	★	★

Applies filter to just show the images in the ImageViewer
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 16492

qmlUiKirigami/AlbumDelegate.qml

qmlUiKirigami/AlbumView.qml

qmlUiKirigami/ImageViewer.qml

qmlUiKirigami/main.qml

src/imagelistmodel.h

src/imagelistmodel.cpp

src/qmlplugins.cpp

src/roles.h

src/sortmodel.h

src/sortmodel.cpp

Applies filter to just show the images in the ImageViewerClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 16492

qmlUiKirigami/AlbumDelegate.qml

qmlUiKirigami/AlbumView.qml

qmlUiKirigami/ImageViewer.qml

qmlUiKirigami/main.qml

src/imagelistmodel.h

src/imagelistmodel.cpp

src/qmlplugins.cpp

src/roles.h

src/sortmodel.h

src/sortmodel.cpp

Applies filter to just show the images in the ImageViewer
ClosedPublic
Actions

Revision Contents
Changeset List