Correctly access OutputWidget/StandardOutputView::setTitle()
ClosedPublic

Authored by croick on Jul 9 2017, 11:20 PM.

Details

Summary
  • fix crash which was possible when removing the Run toolview after starting a unit test and then restarting a test with closed toolview
  • title was not set correctly for new jobs when tabs of the OutputView were closed
Test Plan
  • start a unit test
  • close the Run toolview
  • start another unit test
  • start a unit test, click on "Close all other output views"
  • start another unit test, check the tab title

Diff Detail

Repository
R33 KDevPlatform
Branch
output
Lint
No Linters Available
Unit
No Unit Test Coverage
croick created this revision.Jul 9 2017, 11:20 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJul 9 2017, 11:20 PM
croick retitled this revision from Correctly access OutputView::setTitle() to Correctly access OutputWidget/StandardOutputView::setTitle().Jul 9 2017, 11:25 PM
kfunk added a subscriber: kfunk.Jul 9 2017, 11:27 PM
kfunk added inline comments.
plugins/standardoutputview/outputwidget.cpp
678 ↗(On Diff #16418)

Is this check really necessary?

data->outputdata isn't accessed further in this function.

croick updated this revision to Diff 16469.Jul 10 2017, 8:08 PM
  • remove redundant check for id in outputdata
croick marked an inline comment as done.Jul 10 2017, 8:10 PM
croick added inline comments.
plugins/standardoutputview/outputwidget.cpp
678 ↗(On Diff #16418)

No, it's not. Thanks. I just copied from removeOutput() which implicitly needs the check.

kfunk accepted this revision.Jul 10 2017, 9:41 PM

Will push.

This revision is now accepted and ready to land.Jul 10 2017, 9:41 PM
This revision was automatically updated to reflect the committed changes.