Remove legacy shaders and remove check for legacy GLSL
ClosedPublic

Authored by Nim on Dec 15 2015, 3:32 PM.

Details

Summary

Removes check for GLSL 1.3 from kis_opengl_canvas2 and removes the legacy shaders that were loaded there.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Nim updated this revision to Diff 1521.Dec 15 2015, 3:32 PM
Nim retitled this revision from to Remove legacy shaders and remove check for legacy GLSL.
Nim updated this object.
Nim edited the test plan for this revision. (Show Details)
Nim added a reviewer: Krita.
Nim set the repository for this revision to R37 Krita.
Nim added a project: Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptDec 15 2015, 3:32 PM
Nim updated this revision to Diff 1522.Dec 15 2015, 3:52 PM

Completely purged supportsGLSL13

kossebau added inline comments.
krita/ui/opengl/kis_opengl_canvas2.cpp
673

I would propose to completely skip this intermediate var 'vertexShaderName' and directly use the string in the one place
result = d->checkerShader->addShaderFromSourceFile(QOpenGLShader::Vertex, ":/matrix_transform.vert");

That would be consistent with similar lines in the codebase below. And simpler code IMHO :)

Same with 'fragmentShaderName'

This revision was automatically updated to reflect the committed changes.